Central European Time - DST

Welcome, Guest.
carstensyabb
modforum
Forgot password?     Register!        
Pages: 1 2 
YaBB Administration Center Version Information fix
Read 557 times
 

Offline xnoddyx
YaBB Friend
***
Posts: 290
     
 
YaBB Administration Center Version Information fix
19. Jul 2013 at 03:44
 
Bug post by RonS2

at least as far back as YaBB 2.4 there is a code error with Version Information due to missing variable if YaBB is unable to retriever this variable from
http://www.yabbforum.com/​update/versioncheck.js

the variable is var STABLE;


CodeSelect All
  <script language="JavaScript" type="text/javascript">
  <!-- //hide from dinosaurs
	var STABLE;
  // -->
  </script> 



My fix is not to re add the missing code but to put a proper check in the code.

in Admin.pl find

CodeSelect All
if (!STABLE) { 




and replace it with

CodeSelect All
if (typeof STABLE == "undefined" || STABLE == null ) { 

 
 

oh-no_5_4_3_2_1_pop.gif
IP Logged   MSIE 10.0  Windows 7  
 
     

Offline Carsten
Administrator
*****
Posts: 996
     
 
Re: YaBB Administration Center Version Information fix
Reply #1 - 19. Jul 2013 at 04:27
 
Now that the lid is off - there's more trouble with 'STABLE' (and 'BETA') in the Admin.pl:

For Forum Statistics:
find:
CodeSelect All
          document.write("$versiontxt{'4'} <b>$YaBBversion</b> - $versiontxt{'5'} <b>"+STABLE+"</b> <p>");   


and replace it with:
CodeSelect All
	if (typeof STABLE == "undefined" || STABLE == null ) {
          document.write("$versiontxt{'4'} <b>$YaBBversion</b> - $versiontxt{'5'} <b>$rna</b> <p>");
	} else {
          document.write("$versiontxt{'4'} <b>$YaBBversion</b> - $versiontxt{'5'} <b>"+STABLE+"</b> <p>");
	} 



For Detailed Version Check:
find:
CodeSelect All
			document.write("$versiontxt{'5'} <b>"+STABLE+"</b><br />$versiontxt{'7'} <b>"+BETA+"</b>");   


and replace it with:
CodeSelect All
		if (typeof STABLE == "undefined" || STABLE == null) {
			document.write("$versiontxt{'5'} <b>$rna</b><br />$versiontxt{'7'} <b>$rna</b>");
		} else {
			document.write("$versiontxt{'5'} <b>"+STABLE+"</b><br />$versiontxt{'7'} <b>"+BETA+"</b>");
		} 

 
 

Smiley If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
  WWWGtalkFacebook
IP Logged   Firefox 22.0  Windows Vista  
 
     

Offline xnoddyx
YaBB Friend
***
Posts: 290
     
 
Re: YaBB Administration Center Version Information fix
Reply #2 - 19. Jul 2013 at 05:38
 
Quote - Carsten wrote on 19. Jul 2013 at 04:27
Now that the lid is off - there's more trouble with 'STABLE' (and 'BETA') in the Admin.pl:

i haven't even though of that code may have been needing to be edited.  Embarrassed
is it ok to post this over to yabbforum?
 
 

oh-no_5_4_3_2_1_pop.gif
IP Logged   MSIE 10.0  Windows 7  
 
     

Offline Bill Myers
YaBB Friend
***
Posts: 396
     
 
Re: YaBB Administration Center Version Information fix
Reply #3 - 19. Jul 2013 at 08:48
 
Quote - xnoddyx wrote on 19. Jul 2013 at 03:44
... at least as far back as YaBB 2.4 there is a code error with Version Information due to missing variable if YaBB is unable to retrieve ...

I guess our 2.4 forum has gotten lucky with good coding that works as follows:

Edited
Quote - Bill Myers wrote on 19. Jul 2013 at 17:32
This morning when I checked it out, snap, I was able to see the errors that were mentioned (even without a reload). Smiley


Note: I took out the code I previously used to make point, which was obviously in error.  Embarrassed

As for the question I asked below, obviously the answer is yes. Shocked


*************************​*************************​*******

Quote - Carsten wrote on 19. Jul 2013 at 04:27
... there's more trouble with 'STABLE' (and 'BETA') in the Admin.pl ...

I'm not noticing anything broken in our 2.4 forum. So, should I be implementing the changes presented here?
 
 
« Last Edit: 19. Jul 2013 at 17:38 by Bill Myers »  

Morning, noon, or night, have a great one! dansing.gif
IP Logged   Firefox 22.0  Windows 7  
 
     

Offline Carsten
Administrator
*****
Posts: 996
     
 
Re: YaBB Administration Center Version Information fix
Reply #4 - 19. Jul 2013 at 09:23
 
Quote - Bill Myers wrote on 19. Jul 2013 at 08:48
I guess our 2.4 forum has gotten lucky with good coding that works as follows:

Try this Bill: Go to your Admin Centre front page and do a reload.
 
 

Smiley If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
  WWWGtalkFacebook
IP Logged   Firefox 22.0  Windows Vista  
 
     

Offline Carsten
Administrator
*****
Posts: 996
     
 
Re: YaBB Administration Center Version Information fix
Reply #5 - 19. Jul 2013 at 09:40
 
Quote - xnoddyx wrote on 19. Jul 2013 at 05:38
is it ok to post this over to yabbforum?

Of course Wink
 
 

Smiley If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
  WWWGtalkFacebook
IP Logged   Firefox 22.0  Windows Vista  
 
     

Offline xnoddyx
YaBB Friend
***
Posts: 290
     
 
Re: YaBB Administration Center Version Information fix
Reply #6 - 19. Jul 2013 at 13:23
 
Quote - Bill Myers wrote on 19. Jul 2013 at 08:48
I guess our 2.4 forum has gotten lucky with good coding that works as follows:

the error looks like this in ff
ScreenHunter_048.jpg

and in ie it looks like this
vie.jpg
and what it should look like
sll.jpg
 
 
« Last Edit: 19. Jul 2013 at 13:30 by xnoddyx »  

vie.jpg (25 KB | 16 )
vie.jpg
sll.jpg (49 KB | 15 )
sll.jpg

oh-no_5_4_3_2_1_pop.gif
IP Logged   MSIE 10.0  Windows 7  
 
     

Offline Dandello
Mod Writer
***
Posts: 597
     
 
Re: YaBB Administration Center Version Information fix
Reply #7 - 19. Jul 2013 at 17:04
 
I do like this:
Quote
YOUR version: YaBB 2.5.4
Latest RELEASE version: Remote Server not available!
Latest BETA version: Remote Server not available!

(Okay - not so keen on the fact that the remote server isn't available. Roll Eyes )

Thanks guys!  Smiley
 
 

If you have only one solution to a problem, you're not trying!
 
IP Logged   Firefox 22.0  Windows XP  
 
     

Offline Bill Myers
YaBB Friend
***
Posts: 396
     
 
Re: YaBB Administration Center Version Information fix
Reply #8 - 19. Jul 2013 at 17:32
 
Quote - Carsten wrote on 19. Jul 2013 at 09:23
Try this Bill: Go to your Admin Centre front page and do a reload.

This morning when I checked it out, snap, I was able to see the errors that were mentioned (even without a reload). Smiley

I'm sending an even bigger thanks to you for providing the information to fix those errors. I made the edits that both you and xnoddyx provided, and they worked like a charm. I'm very appreciative!

I have to wonder how unstable my own forum would end up being without the invaluable help you continue to provide. It's embarrassingly frustrating for me personally not to have the knowledgeable skills you have that enable you to manage YaBB's software so well.

So please, please, please know you are very much needed, and that's in reference to your thoughts about whether or not you should continue to offer support.

*************************​*************************​*******

Quote - xnoddyx wrote on 19. Jul 2013 at 13:23
the error looks like this in ff
Smiley
Please know that I appreciate your continuing efforts as well. I've already lost count on the number of times you've helped me with YaBB. I don't have that many fingers and toes to keep up a good tally. Cheesy

*************************​*************************​*******

And Dandello squeezed in her reply before I could finish mine. She's been an enormous help! Smiley

 
 

Morning, noon, or night, have a great one! dansing.gif
IP Logged   Firefox 22.0  Windows 7  
 
     

Offline xnoddyx
YaBB Friend
***
Posts: 290
     
 
Re: YaBB Administration Center Version Information fix
Reply #9 - 20. Jul 2013 at 03:36
 
Quote - Carsten wrote on 19. Jul 2013 at 09:40
Of course wink.gif

thank you just had to check.  Smiley
 
 

oh-no_5_4_3_2_1_pop.gif
IP Logged   MSIE 10.0  Windows 7  
 
     

Offline RonS2
Senior Member
****
Posts: 240
     
 
Re: YaBB Administration Center Version Information fix
Reply #10 - 20. Jul 2013 at 17:11
 
Thanks for the fix. I applied both xnoddyx and Carsten's

I think its working, my guess is its not reading the info from yabbforum?

 
 

ScreenHunter_052.jpg (23 KB | 12 )
ScreenHunter_052.jpg
 
IP Logged   Firefox 22.0  Windows XP  
 
     

Offline Dandello
Mod Writer
***
Posts: 597
     
 
Re: YaBB Administration Center Version Information fix
Reply #11 - 20. Jul 2013 at 18:01
 
That's exactly it - the javascript over at YaBBForum isn't available or is blocked for whatever reason. xnoddyx has mentioned the possibility that there's some sort of limit as to how many requests are being allowed on that file.
 
 

If you have only one solution to a problem, you're not trying!
 
IP Logged   Firefox 22.0  Windows XP  
 
     

Offline RonS2
Senior Member
****
Posts: 240
     
 
Re: YaBB Administration Center Version Information fix
Reply #12 - 20. Jul 2013 at 19:44
 
Funny thing is it reads it from the 2.5.4 install I have
 
 

 
IP Logged   Firefox 22.0  Windows XP  
 
     

Offline Carsten
Administrator
*****
Posts: 996
     
 
Re: YaBB Administration Center Version Information fix
Reply #13 - 20. Jul 2013 at 20:07
 
That'll be because the javascript referred to in the AdminCentre.template (2.5.4) is located on our very own Dandello's place Wink Wink


CodeSelect All
<script src="http://testbed.dandello.net/update/versioncheck.js" type="text/javascript"></script> 



While all other checks refer to the non-working:


CodeSelect All
<script src="http://www.yabbforum.com/update/versioncheck.js" type="text/javascript"></script> 

 
 
« Last Edit: 20. Jul 2013 at 20:10 by Carsten »  

Smiley If you knock your head against a brick wall and hear a hollow sound, it's not necessarily coming from the wall.
  WWWGtalkFacebook
IP Logged   Firefox 22.0  Windows Vista  
 
     

Offline RonS2
Senior Member
****
Posts: 240
     
 
Re: YaBB Administration Center Version Information fix
Reply #14 - 20. Jul 2013 at 20:08
 
Most Excellent Smiley!
 
 
 
IP Logged   Firefox 22.0  Windows XP  
 
     
Pages: 1 2 
Previous Topic - 'No Guest Links' and Moved TopicsNext Topic - Edit tag issues  
Carsten's YaBB Mod Forum » Powered by YaBB 2.4!
YaBB © 2000-2009. All Rights Reserved.